Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: publish the wind information to gz and ros topic #2767

Open
wants to merge 3 commits into
base: gz-sim9
Choose a base branch
from
Open

ADD: publish the wind information to gz and ros topic #2767

wants to merge 3 commits into from
+14 −0

Conversation

TigerWuu
Copy link

Signed-off-by: TigerWuu [email protected]

🎉 New feature

Summary

Create a wind plugin : windEffectPub to publish the wind information from gazebo to

  1. gz topic : /world/$myworld$/wind_info
  2. ros2 topic : /data/wind_true

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Feb 12, 2025
@TigerWuu TigerWuu marked this pull request as ready for review February 12, 2025 10:55
@TigerWuu TigerWuu requested a review from mjcarroll as a code owner February 12, 2025 10:55
arjo129
arjo129 reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting really close to ☑️ ... Just one more small ask from me. Also update the docstring in the header file with info about how to access this topic.

src/systems/wind_effects/WindEffects.cc
@@ -482,6 +485,10 @@ void WindEffectsPrivate::SetupTransport(const std::string &_worldName)
// Wind info service
this->node.Advertise("/world/" + validWorldName + "/wind_info",
&WindEffectsPrivate::WindInfoService, this);

// Wind info topic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! It'd be nice if we could toggle this on and off. Do you mind adding an optional SDFormat parameter to the Configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 requested changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TigerWuu @arjo129