Use const ref

Signed-off-by: Steve Peters <[email protected]>
gazebosim · Jul 13, 2023 · a7e4513 · a7e4513
1 parent d7f552f
commit a7e4513
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/dartsim/src/JointFeatures.cc b/dartsim/src/JointFeatures.cc
@@ -728,8 +728,8 @@ Wrench3d JointFeatures::GetJointTransmittedWrenchInJointFrame(
 void JointFeatures::SetJointMimicConstraint(
     const Identity &_id,
     const std::size_t /*_dof*/,  // follower dof not supported by dart API yet
-    const std::string _joint,
-    const std::string,
+    const std::string &_joint,
+    const std::string &/*_axis*/,
     const double _multiplier,
     const double _offset,
     const double _reference)

diff --git a/dartsim/src/JointFeatures.hh b/dartsim/src/JointFeatures.hh
@@ -210,8 +210,8 @@ class JointFeatures :
   public: void SetJointMimicConstraint(
       const Identity &_id,
       const std::size_t _dof,
-      const std::string _joint,
-      const std::string _axis,
+      const std::string &_joint,
+      const std::string &_axis,
       const double _multiplier,
       const double _offset,
       const double _reference) override;

diff --git a/include/gz/physics/Joint.hh b/include/gz/physics/Joint.hh
@@ -610,8 +610,8 @@ namespace gz
 
         public: void SetMimicConstraint(
                     const std::size_t _dof,
-                    const std::string _joint,
-                    const std::string _axis,
+                    const std::string &_joint,
+                    const std::string &_axis,
                     Scalar _multiplier,
                     Scalar _offset,
                     Scalar _reference);
@@ -627,8 +627,8 @@ namespace gz
         public: virtual void SetJointMimicConstraint(
             const Identity &_id,
             const std::size_t _dof,
-            const std::string _joint,
-            const std::string _axis,
+            const std::string &_joint,
+            const std::string &_axis,
             Scalar _multiplier, Scalar _offset, Scalar _reference) = 0;
       };
     };

diff --git a/include/gz/physics/detail/Joint.hh b/include/gz/physics/detail/Joint.hh
@@ -221,8 +221,8 @@ namespace gz
     void SetMimicConstraintFeature::Joint<PolicyT, FeaturesT>::
     SetMimicConstraint(
       const std::size_t _dof,
-      const std::string _joint,
-      const std::string _axis,
+      const std::string &_joint,
+      const std::string &_axis,
       Scalar _multiplier, Scalar _offset, Scalar _reference)
     {
       this->template Interface<SetMimicConstraintFeature>()