python bindings: get version from package.xml #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Implements feature request from #636 (comment) using gazebosim/gz-cmake#456 from gz-cmake 4.1.0, replaces prototype in #639
Summary
When building python bindings separately from the main library, the major version of gz-math has been hard-coded, but this changes it to parse the gz-math version number from the
package.xml
file in this repository using a gz-cmake feature added in gazebosim/gz-cmake#456 and released in 4.1.0. We could also consider using this feature in the root CMakeLists.txt file, but for now it is just used when building python bindings separately from the main library.Test it
src/python_pybind11
folder:gz-math8
and configured with version 8.0.0Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.