Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python bindings: get version from package.xml #642

Open
wants to merge 1 commit into
base: gz-math8
Choose a base branch
from

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 9, 2024

🎉 New feature

Implements feature request from #636 (comment) using gazebosim/gz-cmake#456 from gz-cmake 4.1.0, replaces prototype in #639

Summary

When building python bindings separately from the main library, the major version of gz-math has been hard-coded, but this changes it to parse the gz-math version number from the package.xml file in this repository using a gz-cmake feature added in gazebosim/gz-cmake#456 and released in 4.1.0. We could also consider using this feature in the root CMakeLists.txt file, but for now it is just used when building python bindings separately from the main library.

Test it

  1. Configure the src/python_pybind11 folder:
cd src/python_pybind11
mkdir build
cd build
cmake ..
  1. Verify that it found gz-math8 and configured with version 8.0.0
-- Looking for gz-math8 -- found version 8.0.0

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Requires gz-cmake4 4.1.0.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant