Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove major version from package name #286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebo-tooling/release-tools#1244.

Summary

This removes the major version from the package name in the following places:

  • cmake project name
  • package.xml name

An additional change was needed to resolve a name collision between cmake targets. In Ionic, the core library target name is gz-launch8, and the executable implementing the gz launch command has a target name of gz-launch. Removing the major version from the cmake project changes the core library target name to gz-launch, causing a name collision. To resolve this, the executable target name is changed, while setting its OUTPUT_NAME property to gz-launch to retain the same output file name.

Test it

  • Check CI results

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Update cmake project name, package.xml name
* Change gz-launch executable target name to avoid
  conflict with library target name. Set the
  OUTPUT_NAME property to retain same executable
  file name.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

windows build is unhappy since it doesn't find gz-launch9 in the workspace; we would need to update our build scripts to handle package names without a major version, which shouldn't be too hard since we already have logic for supporting gz- and ignition- prefixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant