Remove major version from package name #286
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebo-tooling/release-tools#1244.
Summary
This removes the major version from the package name in the following places:
An additional change was needed to resolve a name collision between cmake targets. In Ionic, the core library target name is
gz-launch8
, and the executable implementing thegz launch
command has a target name ofgz-launch
. Removing the major version from the cmake project changes the core library target name togz-launch
, causing a name collision. To resolve this, the executable target name is changed, while setting itsOUTPUT_NAME
property togz-launch
to retain the same output file name.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.