-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve install instructions for macOS #414
Conversation
Signed-off-by: Ryan Govostes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! As you said, there are a lot of different changes in this pull request, some of which I am ready to approve immediately, but others will require more discussion. In particular, I am ready to immediately approve the following changes:
- Using
curl
instead ofwget
, which is not built-in.- Partially addresses Change references from OS X to macOS #106.
if you want to split these out into a separate pull request and propagate the changes to other documentation files, I'll be happy to review it
# qt@5 | ||
export CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}:/opt/homebrew/opt/qt@5 | ||
export CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH:+$CMAKE_PREFIX_PATH:}`brew --prefix qt@5` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you changed the syntax to ${CMAKE_PREFIX_PATH:+$CMAKE_PREFIX_PATH:}
. I think it's easier to read the original syntax. I also think it's a little easier to read the $(...)
instead of backticks
export CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH:+$CMAKE_PREFIX_PATH:}`brew --prefix qt@5` | |
export CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}:$(brew --prefix qt@5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${CMAKE_PREFIX_PATH:+$CMAKE_PREFIX_PATH:}
is the unfortunate shell (Bash, Zsh) syntax for "append a : delimiter after the variable if it has a value". Otherwise if CMAKE_PREFIX_PATH
is not set and you write ${CMAKE_PREFIX_PATH}:/opt/homebrew
you get :/opt/homebrew
.
Signed-off-by: Addisu Z. Taddese <[email protected]>
Summary
Several improvements to the install instructions for macOS including,
curl
instead ofwget
, which is not built-in.I've only made the changes to Harmonic so far, but once approved they can be applied to Ionic as well.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.