Make Citadel to use custom ciconfig to exclude gz-sim/gz-launch #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Blast545
reviewed
Dec 15, 2023
| @@ -96,7 +96,7 @@ collections: | |||
| configs: | |||
| - focal | |||
| - brew | |||
| - win | |||
There was a problem hiding this comment.
IIUC this PR this line has to be kept(? Then you would have focal, brew, win and win_citadel configs
There was a problem hiding this comment.
Note that this config section is defining the configurations for Citadel so win is replaced by win_citadel.
You are right about that now we have 4 configurations available, with winstill defined generally in the ci_configs section and used for Fortress, Garden, Harmonic, Ionic and upcoming.
There was a problem hiding this comment.
Oh, I see, thanks for the explanation
Blast545
reviewed
Dec 15, 2023
Blast545
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to exclude gz-sim and gz-launch from Citadel. To avoid adding harcoded values in the DSL, the declarative approach is to create a new ciconfig for Citadel, just by duplicating the win configuration and make the exclusions for the libraries.