Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuefix #39151

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Issuefix #39151

wants to merge 8 commits into from

Conversation

emmron
Copy link

@emmron emmron commented Nov 2, 2024

Description

Documentation

Tests

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 2, 2024
@emmron
Copy link
Author

emmron commented Nov 2, 2024

This pull request includes several updates to improve type safety, add new utility functions, and fix import paths. The most important changes are the addition of type annotations in various functions, the introduction of a new utility function to match path parameters, and the correction of import paths.

Type Safety Improvements:

  • Added type annotations to various functions in resolve-module-exports.ts to improve type safety and code clarity. [1] [2] [3] [4] [5]

New Utility Functions:

  • Introduced a new function matchPathParams in resolve-module-exports.ts to handle path matching and decoding for SSR.

Import Path Fixes:

  • Corrected the import path for pick from @gatsbyjs/reach-router to @reach/router in find-page-by-path.ts.
  • Added missing imports for fs-extra, path, and createContentDigest in gatsby-node.js.
  • Added an import for match from @reach/router in resolve-module-exports.ts.

Copy link
Author

@emmron emmron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

@emmron emmron closed this Nov 2, 2024
@emmron emmron reopened this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant