Remove nixpkgs input #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `nixpkgs` dependency was only being used for library functions, and these functions are only needed within `garnixModules.default` which receives `lib` from `garnix-lib`. By removing the `nixpkgs` input we can be assured that there is only one `nixpkgs` being used: the one passed in from `garnix-lib`. One note that differs with the `nodejs-module`: the `dream2nix` input needs a `nixpkgs` flake input so there still may be a discrepancy here. However, as far as I can tell, this will only affect what NodeJS will be used, all of the NixOS configuration will be based on the `nixpkgs` provided by `garnix-lib`. That being said, do we still want an unused `nixpkgs` input for this module so that downstream users can easily use `inputs.nodejs-module.inputs.nixpkgs.follows` to change the `nixpkgs` version providing NodeJS? To make this commit easier to review, I am only moving the function definition around and not changing formatting at all. I will reformat with `nixfmt` in the next commit.
I think so, yes. Also to document that there is another |
soenkehahn
approved these changes
Mar 4, 2025
This makes it clear that `dream2nix` is consuming a `nixpkgs` and makes it easy to override. However, all other usage of `nixpkgs` within this flake are still removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nixpkgsdependency was only being used for library functions, andthese functions are only needed within
garnixModules.defaultwhichreceives
libfromgarnix-lib. By removing thenixpkgsinput we canbe assured that there is only one
nixpkgsbeing used: the one passedin from
garnix-lib.One note that differs with the
nodejs-module: thedream2nixinput needs a
nixpkgsflake input so there still may be a discrepancyhere. However, as far as I can tell, this will only affect what NodeJS
will be used, all of the NixOS configuration will be based on the
nixpkgsprovided bygarnix-lib. That being said, do we still want anunused
nixpkgsinput for this module so that downstream users can easilyuse
inputs.nodejs-module.inputs.nixpkgs.followsto change thenixpkgsversion providing NodeJS?