Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address prefix issue #9

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix address prefix issue #9

merged 2 commits into from
Jul 8, 2024

Conversation

AUsfy
Copy link
Contributor

@AUsfy AUsfy commented Jul 7, 2024

Use AddressPrefixes field instead of AddressPrefix which could be null
Issue #8

@gamullen gamullen merged commit c9b8cf7 into gamullen:main Jul 8, 2024
@AUsfy
Copy link
Contributor Author

AUsfy commented Jul 9, 2024

Adding some documentation about the issue & fix :

  • Issue Description:
    The code is failing for new VNets and returns an 500 error.

  • Observation:
    I think there has been a recent change in the data representation for subnets. Previously, the field AddressPrefix contained the address prefix of the subnet. Now, this field is empty and the data is found in another field, AddressPrefixes which is an array. We can see it also in the subnet ARM representation in Azure:

image

  • Proposed Solution:
    Update the code to use both AddressPrefix and AddressPrefixes fields to ensure compatibility with both old and new VNets/Subnets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants