Added timeout to send for tcp_client and tcp_client-windows #3355
+72
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the logs and undo example changes. Also please remove the |
|
I made the changes. And the appveyor builds are successful |
gabime
requested changes
Mar 8, 2025
|
|
||
| // try to connect or throw on failure | ||
| void connect(const std::string &host, int port) { | ||
| // Added timeout_ms parameter (in milliseconds) |
There was a problem hiding this comment.
Please fix the comment. is it for connect only? for read and write? in seconds?
example/example.cpp
Outdated
| // Mapped Diagnostic Context (MDC) is a map that stores key-value pairs (string values) in thread | ||
| // local storage. Each thread maintains its own MDC, which loggers use to append diagnostic | ||
| // information to log outputs. Note: it is not supported in asynchronous mode due to its reliance on | ||
| // thread-local storage. |
There was a problem hiding this comment.
Done, should I take the latest example from the repo.
| ::setsockopt(socket_, SOL_SOCKET, SO_RCVTIMEO, reinterpret_cast<char *>(&timeout), | ||
| sizeof(timeout)); | ||
| ::setsockopt(socket_, SOL_SOCKET, SO_SNDTIMEO, reinterpret_cast<char *>(&timeout), | ||
| sizeof(timeout)); |
There was a problem hiding this comment.
i dont think it affects connect timeout. only recv and send
There was a problem hiding this comment.
Yes it only send and recv timeout, I can do it for connect but it would be non blocking I guess. Can I proceed with that ?
There was a problem hiding this comment.
I am confused. Isn't the connect timeout is the whole point of this pr?
LowLevelLore
commented
Mar 13, 2025
|
|
||
| // try to connect or throw on failure | ||
| void connect(const std::string &host, int port) { | ||
| // Added timeout_ms parameter (in milliseconds) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is against the issue: "Add timeout parameter to tcp_client::connect() #2682"
I have set socket options of SO_RCVTIMEO and SO_SNDTIMEO in the connect method of tcp_client (both normal and windows) to set the timeout that was passed in the constructor. Now the struct tcp_sink_config has extra timeout_sec parameter. Now when the tcp_client::connect() times out, it also throws an error.
Please guide me this is my first PR.