Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up WASM platform lookups #5519

Merged
merged 6 commits into from
Feb 8, 2025
Merged

Clean up WASM platform lookups #5519

merged 6 commits into from
Feb 8, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Feb 8, 2025 •
edited
Loading

Description:

Avoids keeping global references to some WASM state that was unnecessary and also moves the macOS check to only be looked up once.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Feb 8, 2025 •
edited
Loading

Coverage Status

coverage: 62.606%. remained the same
when pulling 0d7c784 on Jacalz:wasm-mobile-lookup-cleanup
into 9677021 on fyne-io:develop.

@Jacalz Jacalz changed the title Don't keep around unused regexp for WASM mobile lookup Clean up WASM platform lookups Feb 8, 2025
andydotxyz
andydotxyz approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Jacalz Jacalz merged commit aff36fb into fyne-io:develop Feb 8, 2025
11 checks passed
@Jacalz Jacalz deleted the wasm-mobile-lookup-cleanup branch February 8, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz