Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up leftovers from making bindings generic #5507

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Clean up leftovers from making bindings generic #5507

merged 3 commits into from
Feb 10, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Feb 5, 2025

Description:

I finally managed to clean up preferences bindings (and move them to the right file) but I also removed some duplication from convertions.

Checklist:

  • Tests included. <- covered by existing tests
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Feb 5, 2025 •
edited
Loading

Coverage Status

coverage: 62.581% (-0.03%) from 62.613%
when pulling ba7effd on Jacalz:binding-cleanup-leftovers
into 71764a2 on fyne-io:develop.

@Jacalz Jacalz force-pushed the binding-cleanup-leftovers branch from a75f74c to ba7effd Compare February 7, 2025 08:59
@Jacalz
Copy link
Member Author

Jacalz commented Feb 7, 2025

Something wonky happened with the merge. Had to rebase and force push to clean up the history :/

andydotxyz
andydotxyz approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andydotxyz andydotxyz merged commit a0a3e58 into fyne-io:develop Feb 10, 2025
11 checks passed
@Jacalz Jacalz deleted the binding-cleanup-leftovers branch February 10, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz