Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TXFIFO register write and timeout message #1604

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix TXFIFO register write and timeout message #1604

wants to merge 4 commits into from
+3 −3

Conversation

gajjarpremal
Copy link

Changes:

  • Fixed incorrect register write for TXFIFO invalidation (FSPI_IPRXFCR → FSPI_IPTXFCR).
  • Corrected error message for TXFIFO wait timeout (FSPI_INTR_IPRXWA → FSPI_INTR_IPTXWE).

Fix TXFIFO register write and timeout message
ae3adf8 
Changes:
- Fixed incorrect register write for TXFIFO invalidation (FSPI_IPRXFCR → FSPI_IPTXFCR).
- Corrected error message for TXFIFO wait timeout (FSPI_INTR_IPRXWA → FSPI_INTR_IPTXWE).
@gajjarpremal
Copy link
Author

Hello jlduran,

I am attempting to merge my changes into FreeBSD for the first time. However, the 'Merge pull request' option appears to be disabled, and I see three workflows awaiting approval. Additionally, I do not have the necessary authorization to complete the merge.

Could you please assist me with this request?

Best regards,
Premal Gajajr

@jlduran
Copy link
Member

jlduran commented Feb 28, 2025

Hi! Thank you for the pull request.
This repository is "read-only". A codeowner should also review this code shortly(TM) and merge it.

@gajjarpremal
Copy link
Author

Thank you, jlduran, for the quick response.

@jlduran
Copy link
Member

jlduran commented Mar 1, 2025

You are welcome!
While here, shouldn't the comment:

freebsd-src/sys/dev/flash/flexspi/flex_spi.c

Line 339 in a18be39

/* Wait for RXFIFO available */

say TXFIFO instead?

Premal Gajjar added 2 commits March 2, 2025 16:14
Fix TXFIFO register write and timeout message
0ced1d3 
Changes:
- Fixed incorrect register write for TXFIFO invalidation (FSPI_IPRXFCR → FSPI_IPTXFCR).
- Corrected error message for TXFIFO wait timeout (FSPI_INTR_IPRXWA → FSPI_INTR_IPTXWE).
- Corrected comment for TXFIFO available (RXFIFO -> TXFIFO)
Merge branch 'flexpi_fix' of https://github.com/gajjarpremal/freebsd-src
09b9edd 
 into flexpi_fix
@gajjarpremal
Copy link
Author

Corrected comment as a suggestion for TXFIFO.

@gajjarpremal
Copy link
Author

Hello jlduran, any updates on this pull request?

@jlduran
Copy link
Member

jlduran commented Mar 18, 2025

Now we'll just wait for some CODEOWNER to review and (hopefully) commit. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlduran jlduran jlduran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gajjarpremal @jlduran