release/amd64: Check config variables instead of checking files #1571
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose configuration variables if we're being sourced. This provides a convenient way to check them in the release scripts. Signed-off-by: Ahmad Khalifa <[email protected]>
Check the MK_LOADER_IA32 variable instead of manually checking if the file exists. Signed-off-by: Ahmad Khalifa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the release script by checking
MK_LOADER_IA32instead of the jankyif -f "${BASEBITSDIR}/boot/loader_ia32.efiI'm hesitant about putting this in install-boot.sh, it feels out of place.
Maybe a new script in release/amd64 that gets sourced by both
make-memstickandmkisoimageswould be better? I'm not sure..This also makes the script complain if
MK_LOADER_IA32isyesbut the file is missing, instead of silently not copying it.FWIW it also allows the user to build the ia32 loader, but omit it from the img, though I'm not sure what the use case would be.
I've been meaning to do this since 599273f landed but forgot, so here it is.