Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make request body required for replace-task endpoint #2355

Merged

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Mar 12, 2025

Ref #2349

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa linked an issue Mar 12, 2025 that may be closed by this pull request
@tcompa tcompa changed the base branch from main to dev-2.14 March 12, 2025 11:02
@tcompa tcompa changed the base branch from dev-2.14 to main March 12, 2025 11:02
Copy link

github-actions bot commented Mar 12, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 1.0 0.80 0.0 0.0
power 0.8 0.9 0.89 0.0 0.0
dataset 0.9 0.8 1.12 0.0 0.0
project 0.9 0.8 1.12 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.8 10.9 0.99 0.6 0.6
power 265.7 249.6 1.06 345.4 345.4
dataset 97.3 87.5 1.11 123.2 123.2
project 29.7 22.0 1.35 43.9 43.9
job 12.5 11.3 1.11 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.8 6.1 1.11 2.2 2.2
power 58.1 51.3 1.13 656.2 656.2
dataset 60.6 51.7 1.17 909.2 909.2
project 25.4 17.6 1.44 285.0 285.0
job 18.2 17.6 1.03 225.9 225.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.9 7.1 1.25 0.1 0.1
power 8.2 6.9 1.19 0.1 0.1
dataset 7.9 6.9 1.14 0.1 0.1
project 9.6 8.0 1.20 2.3 2.3
job 7.7 6.8 1.13 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.4 5.5 1.16 0.8 0.8
power 6.0 5.3 1.13 0.8 0.8
dataset 5.8 5.2 1.12 0.8 0.8
project 5.9 5.2 1.13 0.8 0.8
job 6.7 5.2 1.29 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.1 6.2 1.31 1.6 1.6
power 8.0 6.0 1.33 1.6 1.6
dataset 8.2 6.1 1.34 1.6 1.6
project 8.4 6.2 1.35 1.6 1.6
job 8.4 6.2 1.35 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.6 10.7 1.18 0.8 0.8
power 15.8 14.5 1.09 28.0 28.0
dataset 14.4 12.6 1.14 16.2 16.2
project 15.8 14.3 1.10 20.4 20.4
job 12.8 10.7 1.20 0.8 0.8

POST /api/v2/project/3/dataset/407/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 41.7 38.6 1.08 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.9 4.9 1.20 0.2 0.2
power 5.6 4.5 1.24 0.2 0.2
dataset 8.3 4.5 1.84 0.2 0.2
project 5.3 4.4 1.20 0.2 0.2
job 5.2 4.5 1.16 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 274.5 273.7 1.00 0.2 0.2

@tcompa tcompa marked this pull request as ready for review March 12, 2025 11:07
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  workflowtask.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 34eb83c into main Mar 13, 2025
19 checks passed
@tcompa tcompa deleted the 2349-task-updating-handle-new-parameters-with-default-values branch March 13, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant