Make it obvious even to GHC that mappend is canonical (equal to (<>))
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
commented
Feb 28, 2025
| @@ -71,7 +71,7 @@ instance Sem.Semigroup FilePath where | |||
|
|
|||
| instance M.Monoid FilePath where | |||
| mempty = empty | |||
| mappend = append | |||
| mappend = (<>) | |||
There was a problem hiding this comment.
On GHCs 8.0 and 8.2 this causes the error
Variable not in scope: (<>) :: FilePath -> FilePath -> FilePath
So let's wait with this until we drop support for these GHC versions.
andreasabel
changed the title
mappend is canonical (equal to (<>))
andreasabel
force-pushed
the
mappend-canon
branch
from
7a8ff2c to
5982e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mappend