Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snforge_std api #2885

Closed

Conversation

danielrobotz
Copy link

@danielrobotz danielrobotz commented Jan 27, 2025

Fixes #2808

Closes #

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

Sorry, something went wrong.

@kkawula
Copy link
Member

kkawula commented Jan 29, 2025

Hi @danielrobotz any progress on this?

@danielrobotz
Copy link
Author

Still on it
Will be done in a bit
Still trying to male the tests work

@danielrobotz danielrobotz marked this pull request as ready for review January 30, 2025 11:07
@kkawula kkawula enabled auto-merge January 30, 2025 14:51
@kkawula kkawula disabled auto-merge January 30, 2025 14:51
}

pub use _config_types::*;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

newline

@kkawula
Copy link
Member

kkawula commented Jan 30, 2025

@danielrobotz please check CI errors

@danielrobotz
Copy link
Author

@danielrobotz please check CI errors

Gm sir
I'm having some issues resolving this ci issues on my machine as my changes only affected three files and this ci errors are in entirely different files
I would push updates when I have successfully resolve failing cu test's

@cptartur
Copy link
Member

cptartur commented Feb 3, 2025

@danielrobotz please check CI errors

Gm sir I'm having some issues resolving this ci issues on my machine as my changes only affected three files and this ci errors are in entirely different files I would push updates when I have successfully resolve failing cu test's

@danielrobotz the code that you introduced changes to in this PR is used throughout the project is it is not surprising that a lot of tests are failing. You have to update the logic and the code of the failing tests accordingly.

@cptartur
Copy link
Member

cptartur commented Feb 4, 2025

@danielrobotz please resolve the issues with tests. If you have any specific questions, we're happy to assist.

@cptartur
Copy link
Member

cptartur commented Feb 5, 2025

Closing due to inactivity

@cptartur cptartur closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve snforge_std api
3 participants