Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --version and --fee-token flags #2865

Merged
merged 20 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Bug resulting in value passed for `max_fee` being ignored in cast scripts when using `deploy` with STRK token

#### Removed

- `--fee-token` and `--version` flags, subsequently support for transaction versions other than v3
- Support for ETH transactions in scripts

## [0.36.0] - 2025-01-15

### Forge
Expand Down
17 changes: 5 additions & 12 deletions crates/sncast/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ All subcommand usages are shown for two scenarios - when all necessary arguments
```shell
$ sncast --account my_account \
declare \
--contract-name HelloSncast \
--fee-token strk
--contract-name HelloSncast
```

<details>
Expand All @@ -57,8 +56,7 @@ With arguments taken from `snfoundry.toml` file (default profile name):
<!-- { "ignored": true } -->
```shell
$ sncast declare \
--contract-name HelloSncast \
--fee-token strk
--contract-name HelloSncast
```

<details>
Expand All @@ -80,8 +78,7 @@ transaction_hash: [..]
```shell
$ sncast --account my_account \
deploy --class-hash 0x0227f52a4d2138816edf8231980d5f9e6e0c8a3deab45b601a1fcee3d4427b02 \
--url http://127.0.0.1:5055 \
--fee-token strk
--url http://127.0.0.1:5055
```

<details>
Expand All @@ -102,8 +99,6 @@ With arguments taken from `snfoundry.toml` file (default profile name):
```shell
$ sncast deploy \
--class-hash 0x0227f52a4d2138816edf8231980d5f9e6e0c8a3deab45b601a1fcee3d4427b02 \
--fee-token strk

```

<details>
Expand All @@ -127,8 +122,7 @@ $ sncast \
--contract-address 0x0589a8b8bf819b7820cb699ea1f6c409bc012c9b9160106ddc3dacd6a89653cf \
--function "sum_numbers" \
--arguments '1, 2, 3' \
--url http://127.0.0.1:5055/rpc \
--fee-token strk
--url http://127.0.0.1:5055/rpc
```

<details>
Expand All @@ -152,8 +146,7 @@ $ sncast invoke \
--contract-address 0x0589a8b8bf819b7820cb699ea1f6c409bc012c9b9160106ddc3dacd6a89653cf \
--function "sum_numbers" \
--arguments '1, 2, 3' \
--url http://127.0.0.1:5055/rpc \
--fee-token strk
--url http://127.0.0.1:5055/rpc
```

<details>
Expand Down
39 changes: 0 additions & 39 deletions crates/sncast/src/helpers/error.rs

This file was deleted.

Loading
Loading