feat: enable more clippy lint #10150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taikoonwang
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
DaniPopes
reviewed
Mar 22, 2025
taikoonwang
changed the title
taikoonwang
changed the title
|
Lint rules currently missing with Reth, can be done in a follow-up (or selectively) to not further grow the diff to review borrow_as_ptr = "warn"
branches_sharing_code = "warn"
collection_is_never_read = "warn"
doc_markdown = "warn"
empty_line_after_doc_comments = "warn"
empty_line_after_outer_attr = "warn"
enum_glob_use = "warn"
equatable_if_let = "warn"
if_not_else = "warn"
if_then_some_else_none = "warn"
iter_on_single_items = "warn"
large_stack_frames = "warn"
manual_assert = "warn"
manual_clamp = "warn"
manual_is_variant_and = "warn"
match_same_arms = "warn"
mutex_integer = "warn"
option_as_ref_cloned = "warn"
or_fun_call = "warn"
path_buf_push_overwrite = "warn"
redundant_else = "warn"
single_char_pattern = "warn"
string_lit_as_bytes = "warn"
string_lit_chars_any = "warn"
suboptimal_flops = "warn"
suspicious_operation_groupings = "warn"
trailing_empty_array = "warn"
trait_duplication_in_bounds = "warn"
transmute_undefined_repr = "warn"
trivial_regex = "warn"
tuple_array_conversions = "warn"
type_repetition_in_bounds = "warn"
uninhabited_references = "warn"
unnecessary_self_imports = "warn"
unnecessary_struct_initialization = "warn"
unnested_or_patterns = "warn"
unused_peekable = "warn"
unused_rounding = "warn"
useless_let_if_seq = "warn"
while_float = "warn"
zero_sized_map_values = "warn" |
zerosnacks
reviewed
Mar 25, 2025
DaniPopes
reviewed
Mar 25, 2025
| needless_pass_by_ref_mut = "warn" | ||
| nonstandard_macro_braces = "warn" | ||
| read_zero_byte_vec = "warn" | ||
| redundant_clone = "warn" |
There was a problem hiding this comment.
not a fan of this, I'd rather enable an entire group than have to maintain a manual list of these, can we do something like clippy::all and clippy::whatever instead?
There was a problem hiding this comment.
like this pedantic = "warn"? Isn't this scope a bit too broad? Perhaps we can narrow the scope of this PR a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
close: #10149
Solution
PR Checklist