-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump revm #10051
Draft
klkvr
wants to merge
27
commits into
master
Choose a base branch
from
klkvr/new-revm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: bump revm #10051
+1,372
−965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Created a tracking ticket here to identify dependencies / track blockers / questions: #10116 |
zerosnacks
reviewed
Mar 24, 2025
match err { | ||
EVMError::Database(err) => err.into(), | ||
EVMError::Custom(err) => Self::msg(err), | ||
EVMError::Header(err) => Self::msg(err.to_string()), | ||
EVMError::Precompile(err) => Self::msg(err), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: bluealloy/revm#2207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bumps revm to bluealloy/revm@9e39df5
Depends on foundry-rs/foundry-fork-db#44, paradigmxyz/revm-inspectors#246
Solution
Clone
[email protected]:alloy-rs/evm.git
into the parent of the project rootAt this point this PR only partially migrates
foundry-evm-core
crate. The most impactful change is thatEvm
type is not longer present. Instead block. cfg and tx envs are stored along with transactions on a largetContext
type which also holds db and journal and thus not very nice to pass around.This PR addresses this by re-introducing
Env
type internally, and the mutable borrowing ofEnv
is solved via a helperEnvMut
:foundry/crates/evm/core/src/env.rs
Lines 7 to 33 in 664809e
The idea here is to avoid migrating entire codebase to completely new environment types and refactor this later if we see a nicer approach.
Another big blocker is changed
JournaledState
structure which we don't have decision on yet. I've partially updated code to useJournalInit
but this approach is likely not sound for some cases.PR Checklist