-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.1.0 #188
Release/3.1.0 #188
Conversation
Reviewer's Guide by SourceryThis release includes an increase in the UART timeout, documentation for building for v5 hardware, and updates to the build process to support v5 hardware and create builds for different configurations. The release process was also automated. Updated class diagram for the device versionclassDiagram
class VERSION_FW {
-major: uint8_t
-minor: uint8_t
-patch: uint8_t
}
note for VERSION_FW "Version changed from 3.0.4 to 3.1.0"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
28b1fe4
to
41ac6f6
Compare
41ac6f6
to
9f4bcaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bessman - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a single checkout action and then using
git checkout
to switch between branches. - The release workflow could be simplified by directly using the output of the build job.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -33,6 +43,7 @@ | |||
|
|||
_Major refactorization of firmware._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: "refactorization" should be "refactoring"
_Major refactorization of firmware._ | |
_Major refactoring of firmware._ |
Summary by Sourcery
Prepare for the 3.1.0 release by adding support for building for v5 hardware and ESP01 targets. Update the CI workflow to build multiple targets and create draft releases with attached artifacts automatically.
Build:
CI:
Documentation: