Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UART2 pins not matching labels #178

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

bessman
Copy link
Collaborator

@bessman bessman commented Aug 19, 2024

Fix #177

Summary by Sourcery

Fix UART2 pin assignments to ensure they match the correct labels, addressing the mismatch issue in the pin manager configuration.

Bug Fixes:

  • Correct UART2 pin assignments in the pin manager header and source files to match the correct labels, fixing the mismatch issue.

Copy link

sourcery-ai bot commented Aug 19, 2024

Reviewer's Guide by Sourcery

This pull request fixes an issue where the UART2 pins were not matching their labels. The changes involve swapping the pin assignments for UART2_RX and UART2_TX in both the pin manager header and source files.

File-Level Changes

Files Changes
src/registers/system/pin_manager.h Swapped UART2_RX and UART2_TX pin definitions in the pin manager header
src/registers/system/pin_manager.c Updated UART2 pin mappings in the PIN_MANAGER_Initialize function

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bessman - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@bessman bessman merged commit 5728b36 into fossasia:main Aug 19, 2024
2 checks passed
@bessman bessman deleted the fix/uart2_pins branch August 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UART2 Tx Rx pins mislabelled
1 participant