Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in changelog #176

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fix links in changelog #176

merged 2 commits into from
Jul 30, 2024

Conversation

bessman
Copy link
Collaborator

@bessman bessman commented Jul 30, 2024

Summary by Sourcery

This pull request fixes broken links in the CHANGELOG.md file by adding the missing URLs for versions 3.0.1 and 3.0.2.

  • Documentation:
    • Fixed broken links in the changelog by adding missing URLs for versions 3.0.1 and 3.0.2.

Copy link

sourcery-ai bot commented Jul 30, 2024

Reviewer's Guide by Sourcery

This pull request fixes broken links in the CHANGELOG.md file by adding the correct URLs for versions 3.0.1 and 3.0.2.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bessman - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider standardizing the version format in the links. The 3.0.0 link includes a 'v' prefix ('v3.0.0'), while the new links for 3.0.2 and 3.0.1 don't. Is this intentional or should it be consistent across all versions?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@bessman
Copy link
Collaborator Author

bessman commented Jul 30, 2024

* Consider standardizing the version format in the links. The 3.0.0 link includes a 'v' prefix ('v3.0.0'), while the new links for 3.0.2 and 3.0.1 don't. Is this intentional or should it be consistent across all versions?

Past tags included the 'v' prefix and can't be changed. From now on, tags are X.Y.Z format.

@bessman bessman merged commit 6913f50 into fossasia:main Jul 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant