Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2208 Card Layout Implemented for Generate Config Layout #2210

Conversation

kartikaysharma01
Copy link
Member

Fixes #2208
Fixes #2181

Changes:

  1. Added Card Views for Instrument and Time Interval Sections on Generate Config Screen
  2. Regularized the layout

Screenshot/s for the changes:
2
1

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]
generate-config-layout.zip

@kartikaysharma01
Copy link
Member Author

kartikaysharma01 commented Apr 1, 2021

#2188
To convert logging interval units as slider, I tried using NumberPicker but that is not space feasible in our case.

Another Option was to give more layout weight to spinner but that is a temporary fix as the default vast space between textview and drop down icon makes the fix screen-size dependent. (picture attached)
image

I have left the logging interval unit situation as it was before, my suggestion is we make a custom background for spinner with close textview and drop down icon.

A better approach suggestion for slider effect is also welcome.

PS :- @CloudyPadmal

@CloudyPadmal CloudyPadmal merged commit 22466ea into fossasia:development Jun 4, 2021
@CloudyPadmal CloudyPadmal added the Enhancement Improvement to an existing feature label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Layout makeover "Generate Config Files" layout is not uniform.
2 participants