-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time interval units issue solved. #2192
Conversation
The text showing the unit was there but was not visible due to insufficient space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash the commits .
Hi I am new to open source. And by mistake, I closed the pull request instead of squashing. Will that cause trouble ? |
How do I squash the commits ? |
please check the README on you can find how to git squash? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
We opt to do a make over. Closing this trivial fix. |
Fixes #[
#2188 . Note: This will automatically closes the issue.
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]
if the respective task is completed]strings.xml
,dimens.xml
andcolors.xml
without hard-coding themstrings.xml
,dimens.xml
orcolors.xml
APK for testing: [feature.zip]