Fix: User name is overwritten when logging in via Wikimedia SSO

[hongquan]

More fix for #278

The previous fix #279 is not enough, because it solves the case that user logins with email address.
This PR solves the case when user logins via Wikimedia SSO

How has this been tested?

There is no screenshot because I cannot reproduce the bug in my localhost: Wikimedia refuses logging-in, may be because the domain I use for localhost is not valid.

Checklist

• I have added tests to cover my changes.

Summary by Sourcery

Bug Fixes:

• Fixes a bug where a user's name was overwritten when logging in via Wikimedia SSO, by only updating the user's name if it is not already set.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue where a user's name would be overwritten when logging in via Wikimedia SSO, even if the user already had a name set. The fix ensures that the user's name is only updated if it is not already set.

Sequence diagram for user login via Wikimedia SSO

sequenceDiagram
    participant User
    participant OAuth2 Provider
    participant pretalx

    User->>OAuth2 Provider: Authenticates via Wikimedia SSO
    OAuth2 Provider-->>User: Returns user information (email, name, etc.)
    User->>pretalx: Logs in with OAuth2
    pretalx->>pretalx: Get or create user by email
    alt User is new
        pretalx->>pretalx: Set unusable password
    end
    alt User name is not set AND upstream name is available
        pretalx->>pretalx: Update user name
    end
    pretalx->>pretalx: Set user active and staff status
    pretalx-->>User: Logs user in

Loading

File-Level Changes

Change	Details	Files
Prevent overwriting the user's name when logging in via Wikimedia SSO if the user already has a name set.	Added a check to only update the user's name if it is not already set. The user's name is updated with the name provided by the SSO provider.	src/pretalx/eventyay_common/views/auth.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#279	Prevent the speaker name from being overwritten with the JWT value upon login, specifically when logging in via Wikimedia SSO.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @hongquan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why the user's name should only be set if it's currently empty.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}