-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Page width is wider than necessary #281
Fix: Page width is wider than necessary #281
Conversation
Reviewer's Guide by SourceryThis pull request fixes an issue where the page width was wider than necessary, causing a horizontal scrollbar to appear. This was due to the incorrect usage of the tooltip library. The fix involves removing the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hongquan - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great that you've included a screenshot demonstrating the fix.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes #266
Due to wrong usage of tooltip library, the page is wider than necessary and cause horizontal scroll just for blank margin.
To have a quick fix, I delete the usage of tooltip. We will recover it in the future, because the CSS seems to be messy.
How has this been tested?
Checklist