Fix: Login button label is missing

[hongquan]

Many pages share a common button template, so we need to compute it in context processors.

Fixes part of #276

This PR fixes the button label first.
For the top-right "login" link, I haven't figured out how it should be yet.

How has this been tested?

Checklist

• I have added tests to cover my changes.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes the missing login button label by dynamically generating it from context processors based on the call_for_speaker_login_button_label configuration. It introduces a new context processor in pretalx/orga/context_processors.py to handle the label generation and removes the label generation logic from pretalx/cfp/flow.py.

Sequence diagram for login button label generation

sequenceDiagram
  participant User
  participant Request
  participant ContextProcessors
  participant Settings
  participant Phrases

  User->>Request: Accesses a page
  Request->>ContextProcessors: Calls context processors
  ContextProcessors->>Settings: Retrieves site configuration
  Settings-->>ContextProcessors: Returns site configuration
  ContextProcessors->>Phrases: Retrieves login button label based on configuration
  Phrases-->>ContextProcessors: Returns login button label
  ContextProcessors-->>Request: Adds login button label to context
  Request-->>User: Renders page with login button label

Loading

Updated class diagram for context processors

classDiagram
  class ContextProcessors {
    +orga_events(request)
    +collect_signal(signal, kwargs)
  }

  class Settings {
    +CONFIG
    +BASE_PATH
  }

  class Phrases {
    +CALL_FOR_SPEAKER_LOGIN_BTN_LABELS
  }

  ContextProcessors -- Settings : Uses
  ContextProcessors -- Phrases : Uses

Loading

File-Level Changes

Change	Details	Files
The login button label is now dynamically generated based on the call_for_speaker_login_button_label configuration in the site section.	Added a context processor to compute the login button label. The label is retrieved from the CALL_FOR_SPEAKER_LOGIN_BTN_LABELS dictionary based on the configuration key. A default label is used if the configuration key is missing or invalid. The login button label is added to the context for use in templates.	src/pretalx/orga/context_processors.py src/pretalx/cfp/flow.py

Possibly linked issues

• Missing login button text and not login redirection on speakers area page #276: The PR partially addresses the issue by fixing the login button label, but not the other text/button changes.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @hongquan - I've reviewed your changes - here's some feedback:

Overall Comments:

• It looks like you're duplicating the login button label logic in orga_events and get_context_data; can you consolidate this?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}