Integration tests for chunks configuration

fossabot · Jan 2, 2018 · 5884302 · 5884302
1 parent 52c110f
commit 5884302
Show file tree

Hide file tree

Showing 41 changed files with 335 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -111,6 +111,7 @@
     "karma-phantomjs-launcher": "^1.0.4",
     "karma-sourcemap-loader": "^0.3.7",
     "karma-webpack": "^2.0.3",
+    "lodash.merge": "^4.6.0",
     "lodash.uniq": "^4.5.0",
     "node-sass": "^4.5.2",
     "null-loader": "^0.1.1",

diff --git a/spec/fixtures/project-with-independent-page/node_modules/.DS_Store b/spec/fixtures/project-with-independent-page/node_modules/.DS_Store
diff --git a/spec/fixtures/project-with-independent-page/node_modules/dependencyA/.DS_Store b/spec/fixtures/project-with-independent-page/node_modules/dependencyA/.DS_Store
diff --git a/spec/fixtures/project-with-independent-page/node_modules/dependencyA/index.js b/spec/fixtures/project-with-independent-page/node_modules/dependencyA/index.js
diff --git a/spec/fixtures/project-with-independent-page/node_modules/dependencyA/package.json b/spec/fixtures/project-with-independent-page/node_modules/dependencyA/package.json
diff --git a/spec/fixtures/project-with-independent-page/node_modules/dependencyB/index.js b/spec/fixtures/project-with-independent-page/node_modules/dependencyB/index.js
diff --git a/spec/fixtures/project-with-independent-page/node_modules/dependencyB/package.json b/spec/fixtures/project-with-independent-page/node_modules/dependencyB/package.json
diff --git a/spec/fixtures/project-with-independent-page/sagui.config.js b/spec/fixtures/project-with-independent-page/sagui.config.js
@@ -0,0 +1,7 @@
+module.exports = {
+  pages: ['index', 'about', { name: 'demo', independent: true }],
+  chunks: {
+    vendor: true,
+    common: true,
+  }
+}
diff --git a/spec/fixtures/project-with-independent-page/src/about.html b/spec/fixtures/project-with-independent-page/src/about.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-independent-page/src/about.js b/spec/fixtures/project-with-independent-page/src/about.js
@@ -0,0 +1,5 @@
+import shared from './shared'
+import dependencyA from 'dependencyA'
+
+shared()
+dependencyA()
diff --git a/spec/fixtures/project-with-independent-page/src/demo.html b/spec/fixtures/project-with-independent-page/src/demo.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-independent-page/src/demo.js b/spec/fixtures/project-with-independent-page/src/demo.js
@@ -0,0 +1,7 @@
+import shared from './shared'
+import dependencyA from 'dependencyA'
+import dependencyB from 'dependencyB'
+
+shared()
+dependencyA()
+dependencyB()
diff --git a/spec/fixtures/project-with-independent-page/src/index.html b/spec/fixtures/project-with-independent-page/src/index.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-independent-page/src/index.js b/spec/fixtures/project-with-independent-page/src/index.js
@@ -0,0 +1,5 @@
+import shared from './shared'
+import dependencyB from 'dependencyB'
+
+shared()
+dependencyB()
diff --git a/spec/fixtures/project-with-independent-page/src/shared.js b/spec/fixtures/project-with-independent-page/src/shared.js
@@ -0,0 +1 @@
+export default () => console.log('shared module')
diff --git a/spec/fixtures/project-with-two-pages-disabled-common/sagui.config.js b/spec/fixtures/project-with-two-pages-disabled-common/sagui.config.js
@@ -0,0 +1,6 @@
+module.exports = {
+  pages: ['index', 'about'],
+  chunks: {
+    common: false
+  }
+}
diff --git a/spec/fixtures/project-with-two-pages-disabled-common/src/about.html b/spec/fixtures/project-with-two-pages-disabled-common/src/about.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-two-pages-disabled-common/src/about.js b/spec/fixtures/project-with-two-pages-disabled-common/src/about.js
@@ -0,0 +1,3 @@
+import shared from './shared'
+
+shared()
diff --git a/spec/fixtures/project-with-two-pages-disabled-common/src/index.html b/spec/fixtures/project-with-two-pages-disabled-common/src/index.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-two-pages-disabled-common/src/index.js b/spec/fixtures/project-with-two-pages-disabled-common/src/index.js
@@ -0,0 +1,3 @@
+import shared from './shared'
+
+shared()
diff --git a/spec/fixtures/project-with-two-pages-disabled-common/src/shared.js b/spec/fixtures/project-with-two-pages-disabled-common/src/shared.js
@@ -0,0 +1 @@
+export default () => console.log('shared module')
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/.DS_Store b/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/.DS_Store
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyA/.DS_Store b/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyA/.DS_Store
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyA/index.js b/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyA/index.js
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyA/package.json b/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyA/package.json
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyB/index.js b/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyB/index.js
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyB/package.json b/spec/fixtures/project-with-two-pages-enabled-vendor/node_modules/dependencyB/package.json
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/sagui.config.js b/spec/fixtures/project-with-two-pages-enabled-vendor/sagui.config.js
@@ -0,0 +1,6 @@
+module.exports = {
+  pages: ['index', 'about'],
+  chunks: {
+    vendor: true
+  }
+}
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/src/about.html b/spec/fixtures/project-with-two-pages-enabled-vendor/src/about.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/src/about.js b/spec/fixtures/project-with-two-pages-enabled-vendor/src/about.js
@@ -0,0 +1,5 @@
+import shared from './shared'
+import dependencyA from 'dependencyA'
+
+shared()
+dependencyA()
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/src/index.html b/spec/fixtures/project-with-two-pages-enabled-vendor/src/index.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/src/index.js b/spec/fixtures/project-with-two-pages-enabled-vendor/src/index.js
@@ -0,0 +1,5 @@
+import shared from './shared'
+import dependencyB from 'dependencyB'
+
+shared()
+dependencyB()
diff --git a/spec/fixtures/project-with-two-pages-enabled-vendor/src/shared.js b/spec/fixtures/project-with-two-pages-enabled-vendor/src/shared.js
@@ -0,0 +1 @@
+export default () => console.log('shared module')
diff --git a/spec/fixtures/project-with-two-pages/sagui.config.js b/spec/fixtures/project-with-two-pages/sagui.config.js
@@ -0,0 +1,3 @@
+module.exports = {
+  pages: ['index', 'about']
+}
diff --git a/spec/fixtures/project-with-two-pages/src/about.html b/spec/fixtures/project-with-two-pages/src/about.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-two-pages/src/about.js b/spec/fixtures/project-with-two-pages/src/about.js
@@ -0,0 +1,3 @@
+import shared from './shared'
+
+shared()
diff --git a/spec/fixtures/project-with-two-pages/src/index.html b/spec/fixtures/project-with-two-pages/src/index.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Hello</title>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
+</head>
+<body>
+  <div id="root"></div>
+</body>
+</html>
diff --git a/spec/fixtures/project-with-two-pages/src/index.js b/spec/fixtures/project-with-two-pages/src/index.js
@@ -0,0 +1,3 @@
+import shared from './shared'
+
+shared()
diff --git a/spec/fixtures/project-with-two-pages/src/shared.js b/spec/fixtures/project-with-two-pages/src/shared.js
@@ -0,0 +1 @@
+export default () => console.log('shared module')
diff --git a/spec/integration/index.integration-spec.js b/spec/integration/index.integration-spec.js
@@ -137,6 +137,106 @@ describe('[integration] sagui', function () {
       })
     })
 
+    describe('chunks', () => {
+      describe('project with two pages on build', () => {
+        const projectFixture = path.join(__dirname, '../fixtures/project-with-two-pages')
+        beforeEach(function () {
+          fs.copySync(projectFixture, projectPath, { overwrite: true })
+          return sagui({ projectPath, action: actions.BUILD })
+        })
+
+        it('should have created a common.js file', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          expect(files.filter((file) => file.match(/common.+\.js$/))).not.to.be.empty
+        })
+
+        it('should NOT have created a vendor.js file', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          expect(files.filter((file) => file.match(/vendor.+\.js$/))).to.be.empty
+        })
+      })
+
+      describe('project with two pages and disabled common chunks on build', () => {
+        const projectFixture = path.join(__dirname, '../fixtures/project-with-two-pages-disabled-common')
+        beforeEach(function () {
+          fs.copySync(projectFixture, projectPath, { overwrite: true })
+          return sagui({ projectPath, action: actions.BUILD })
+        })
+
+        it('should not have created a common.js file', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          expect(files.filter((file) => file.match(/common.+\.js$/))).to.be.empty
+        })
+
+        it('should NOT have created a vendor.js file', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          expect(files.filter((file) => file.match(/vendor.+\.js$/))).to.be.empty
+        })
+      })
+
+      describe('project with two pages and enabled vendor chunks on build', () => {
+        const projectFixture = path.join(__dirname, '../fixtures/project-with-two-pages-enabled-vendor')
+        beforeEach(function () {
+          fs.copySync(projectFixture, projectPath, { overwrite: true })
+          return sagui({ projectPath, action: actions.BUILD })
+        })
+
+        it('should have created a common.js file without the content of the node_modules dependencies', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          const commonFiles = files.filter((file) => file.match(/common.+\.js$/))
+          const commonContent = fs.readFileSync(path.join(projectPath, 'dist', commonFiles[0])).toString()
+          expect(commonFiles).not.to.be.empty
+          expect(commonContent).not.to.have.string('dependencyA')
+          expect(commonContent).not.to.have.string('dependencyB')
+        })
+
+        it('should have created a vendor.js file with the content of the node_modules dependencies', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          const vendorFiles = files.filter((file) => file.match(/vendor.+\.js$/))
+          const vendorContent = fs.readFileSync(path.join(projectPath, 'dist', vendorFiles[0])).toString()
+          expect(vendorFiles).not.to.be.empty
+          expect(vendorContent).to.have.string('dependencyA')
+          expect(vendorContent).to.have.string('dependencyB')
+        })
+      })
+
+      describe('project with two pages but one that is independent with vendor and common chunks enabled', () => {
+        const projectFixture = path.join(__dirname, '../fixtures/project-with-independent-page')
+        beforeEach(function () {
+          fs.copySync(projectFixture, projectPath, { overwrite: true })
+          return sagui({ projectPath, action: actions.BUILD })
+        })
+
+        it('should have created a common.js file without the content of the node_modules dependencies, but with the shared content', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          const commonFiles = files.filter((file) => file.match(/common.+\.js$/))
+          const commonContent = fs.readFileSync(path.join(projectPath, 'dist', commonFiles[0])).toString()
+          expect(commonFiles).not.to.be.empty
+          expect(commonContent).not.to.have.string('dependencyA')
+          expect(commonContent).not.to.have.string('dependencyB')
+          expect(commonContent).to.have.string('shared')
+        })
+
+        it('should have created a vendor.js file with the content of the node_modules dependencies', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          const vendorFiles = files.filter((file) => file.match(/vendor.+\.js$/))
+          const vendorContent = fs.readFileSync(path.join(projectPath, 'dist', vendorFiles[0])).toString()
+          expect(vendorFiles).not.to.be.empty
+          expect(vendorContent).to.have.string('dependencyA')
+          expect(vendorContent).to.have.string('dependencyB')
+        })
+
+        it('should include all dependencies and shared code in the independent page', () => {
+          const files = fs.readdirSync(path.join(projectPath, 'dist'))
+          const aboutFiles = files.filter((file) => file.match(/demo.+\.js$/))
+          const aboutContent = fs.readFileSync(path.join(projectPath, 'dist', aboutFiles[0])).toString()
+          expect(aboutContent).to.have.string('dependencyA')
+          expect(aboutContent).to.have.string('dependencyB')
+          expect(aboutContent).to.have.string('shared')
+        })
+      })
+    })
+
     describe('project with duplicated transient dependencies and colliding node_modules', () => {
       const projectWithNodeModules = path.join(__dirname, '../fixtures/project-with-node-modules')
       beforeEach(function () {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export default () => console.log('shared module')