Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked by the maintainers, I split the original PR #1898 to only add
regsecrets.py
while this one is dedicated todpapidump.py
. This current PR CI will fail until the original PR is not merged due to code required.Rest is copy pasted from #1898 :
dpapidump.py
:This script is basically a copy of the
SystemDPAPIdump.py
from @clavoillotte in #1137 that integrates the extraction of secrets fromregsecrets.py
while integrating other small modifications:virtualapp/didlogical
, this credential has always the same file name and does not contain useful information security wise.