fix: use UIDatePickerStyle value for dimension measurements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
approved these changes
Sep 16, 2022
| @@ -80,18 +78,6 @@ export default function Picker({ | |||
| [onChange, value], | |||
| ); | |||
|
|
|||
| React.useEffect( | |||
| function ensureCorrectHeight() { | |||
There was a problem hiding this comment.
On the old architecture, we definitely don't need this, good catch 👍
However, I have not tested my PR with the New Architecture PR. I think the shadow view implementation I've done is only for the old architecture given the rendering on the New Architecture is done in C++. But I am not 100 % sure. @alfonsocj, would you be able to check if this library still works on the New Architecture if you'd merge the changes from here?
| @@ -100,33 +100,10 @@ + (NSString*) datepickerStyleToString: (UIDatePickerStyle) style API_AVAILABLE( | |||
| } | |||
| } | |||
|
|
|||
| RCT_EXPORT_METHOD(getDefaultDisplayValue:(NSDictionary *)options resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) | |||
There was a problem hiding this comment.
This is perfect 👌 I have not realized we can remove this logic.
|
I'm gonna merge this and we can continue the discussion in the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix some more width issues
before
after