Minor printing changes to BMS

formulaslug · May 7, 2024 · 5750b42 · 5750b42
1 parent 8fb0323
commit 5750b42
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/bms/src/BmsConfig.h b/bms/src/BmsConfig.h
@@ -79,7 +79,7 @@ extern DigitalOut* chargerControl;
 //
 // Units: millivolts
 #ifndef BMS_BALANCE_THRESHOLD
-#define BMS_BALANCE_THRESHOLD 3900
+#define BMS_BALANCE_THRESHOLD 3700
 #endif
 
 

diff --git a/bms/src/BmsThread.cpp b/bms/src/BmsThread.cpp
@@ -103,6 +103,7 @@ void BMSThread::threadWorker() {
 
         balanceAllowed = mainToBMSEvent->balanceAllowed;
         charging = mainToBMSEvent->charging;
+        // printf("Balance Allowed: %x\nCharging: %x\n", balanceAllowed, charging);
         delete mainToBMSEvent;
     }
 
@@ -218,7 +219,7 @@ void BMSThread::threadWorker() {
         if (index != -1) {
           allVoltages[(BMS_BANK_CELL_COUNT * i) + index] = voltage;
 
-          // printf("%d: V: %d\n", index, voltage);
+          printf("%d: V: %d\n", index, voltage);
         }
       }
     }
@@ -266,7 +267,7 @@ void BMSThread::threadWorker() {
           uint16_t cellVoltage = allVoltages[i * BMS_BANK_CELL_COUNT + cellNum];
           if (cellVoltage >= BMS_BALANCE_THRESHOLD &&
               cellVoltage >= minVoltage + BMS_DISCHARGE_THRESHOLD) {
-            // printf("Balancing cell %d\n", cellNum);
+            printf("Balancing cell %d\n", cellNum);
             dischargeValue |= (0x1 << j);
           }
         }

diff --git a/bms/src/Main.cpp b/bms/src/Main.cpp
@@ -98,9 +98,11 @@ int main() {
                 for (int i = 0; i < BMS_BANK_COUNT*BMS_BANK_CELL_COUNT; i++) {
                     allVoltages[i] = bmsEvent->voltageValues[i];
                     tsVoltage += allVoltages[i];
+                    //printf("%d, V: %d\n", i, allVoltages[i]);
                 }
                 for (int i = 0; i < BMS_BANK_COUNT*BMS_BANK_TEMP_COUNT; i++) {
                     allTemps[i] = bmsEvent->temperatureValues[i];
+                    //printf("%d, V: %d\n", i, allTemps[i]);
                 }
 
                 break;
@@ -150,6 +152,7 @@ int main() {
     }
 
     isCharging = charge_state_pin;
+    // printf("charge state: %x\n", isCharging);
 
     charge_enable_pin = isCharging && !hasBmsFault && shutdown_measure_pin;