#2: case sensitive params #5
Open
+1,099
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Tue Dec 6 18:47:34 2022 -0500 # # On branch 2-case-sensitive-params # Changes to be committed: # new file: .editorconfig # modified: .gitignore # new file: index.html # modified: package-lock.json # modified: package.json # new file: playwright.config.ts # new file: tests/main.tsx # new file: tests/router.spec.ts # modified: tsconfig.json # # Changes not staged for commit: # modified: tests/router.spec.ts #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #2: captured URL params no longer get transformed to lowercase.
I've also added the repo's first tests. I didn't want to figure out if JSDOM can handle pushstate, so I just set up Playwright to launch Chromium and make assertions in a real browser.