Skip to content

Commit

Permalink
test: avoid running dev-scripts on perf tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed May 14, 2024
1 parent 6aba25d commit bd30407
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
with:
cache: yarn
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
with:
ignore-scripts: true
- run: yarn build
- run: npm run test:perf | tee test/perf/output.txt

Expand Down

3 comments on commit bd30407

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: bd30407 Previous: f404ea2 Ratio
Child logger creation 477878 ops/sec (±1.74%) 470736 ops/sec (±1.14%) 0.99
Logging a string on root logger 827420 ops/sec (±7.06%) 778750 ops/sec (±9.51%) 0.94
Logging an object on root logger 683565 ops/sec (±8.53%) 575629 ops/sec (±7.26%) 0.84
Logging an object with a message on root logger 3052 ops/sec (±242.36%) 10508 ops/sec (±200.86%) 3.44
Logging an object with a redacted prop on root logger 425483 ops/sec (±13.37%) 419402 ops/sec (±10.35%) 0.99
Logging a nested 3-level object on root logger 388307 ops/sec (±7.81%) 363645 ops/sec (±6.46%) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bd30407 Previous: f404ea2 Ratio
Logging an object with a message on root logger 3052 ops/sec (±242.36%) 10508 ops/sec (±200.86%) 3.44

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: bd30407 Previous: 80246cd Ratio
Child logger creation 324294 ops/sec (±0.74%) 327859 ops/sec (±0.65%) 1.01
Logging a string on root logger 795672 ops/sec (±5.25%) 747832 ops/sec (±5.68%) 0.94
Logging an object on root logger 599346 ops/sec (±7.05%) 600381 ops/sec (±4.66%) 1.00
Logging an object with a message on root logger 7653 ops/sec (±201.35%) 10089 ops/sec (±190.05%) 1.32
Logging an object with a redacted prop on root logger 470515 ops/sec (±6.42%) 505630 ops/sec (±6.86%) 1.07
Logging a nested 3-level object on root logger 327295 ops/sec (±4.05%) 337643 ops/sec (±5.19%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.