Skip to content

Commit

Permalink
refactor: naming from pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Jun 19, 2024
1 parent 4827458 commit 96a9f59
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/sfProject.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { ensureNoUppercaseKeys } from './util/findUppercaseKeys';
Messages.importMessagesDirectory(__dirname);
const messages = Messages.loadMessages('@salesforce/core', 'config');

type NamedDirAdditions = {
type NameAndFullPath = {
/**
* The [normalized](https://nodejs.org/api/path.html#path_path_normalize_path) path used as the package name.
*/
Expand All @@ -35,8 +35,8 @@ type NamedDirAdditions = {
fullPath: string;
};

export type NamedPackagingDir = PackagePackageDir & NamedDirAdditions;
export type NamedPackageDir = PackageDir & NamedDirAdditions;
export type NamedPackagingDir = PackagePackageDir & NameAndFullPath;
export type NamedPackageDir = PackageDir & NameAndFullPath;

export type ProjectJson = ConfigContents & ProjectJsonSchema;

Expand Down

3 comments on commit 96a9f59

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 96a9f59 Previous: 4827458 Ratio
Child logger creation 463297 ops/sec (±1.02%) 477442 ops/sec (±1.31%) 1.03
Logging a string on root logger 797989 ops/sec (±8.42%) 832984 ops/sec (±8.52%) 1.04
Logging an object on root logger 611559 ops/sec (±5.78%) 639428 ops/sec (±7.95%) 1.05
Logging an object with a message on root logger 5821 ops/sec (±219.86%) 2635 ops/sec (±243.16%) 0.45
Logging an object with a redacted prop on root logger 460353 ops/sec (±8.93%) 462007 ops/sec (±7.51%) 1.00
Logging a nested 3-level object on root logger 381898 ops/sec (±8.47%) 374667 ops/sec (±7.73%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 96a9f59 Previous: 4827458 Ratio
Logging an object with a message on root logger 2701 ops/sec (±228.76%) 11173 ops/sec (±189.29%) 4.14

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 96a9f59 Previous: 4827458 Ratio
Child logger creation 342108 ops/sec (±0.90%) 324182 ops/sec (±0.76%) 0.95
Logging a string on root logger 841032 ops/sec (±5.79%) 674007 ops/sec (±7.09%) 0.80
Logging an object on root logger 624002 ops/sec (±7.60%) 568433 ops/sec (±6.06%) 0.91
Logging an object with a message on root logger 2701 ops/sec (±228.76%) 11173 ops/sec (±189.29%) 4.14
Logging an object with a redacted prop on root logger 438410 ops/sec (±10.28%) 387374 ops/sec (±16.87%) 0.88
Logging a nested 3-level object on root logger 312842 ops/sec (±7.29%) 301386 ops/sec (±6.25%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.