Skip to content

Commit

Permalink
fix: use env var when key doesn't match v1 or v2 length
Browse files Browse the repository at this point in the history
  • Loading branch information
@shetzel
shetzel committed Feb 7, 2024
1 parent 032ce66 commit 6774418
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/crypto/crypto.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ const detectCryptoVersion = (pwd?: string): void => {
if (sfCryptoV2 === 'true') {
getCryptoLogger().warn(messages.getMessage('v2CryptoWithV1KeyWarning'));
}
} else {
getCryptoLogger().debug("crypto key doesn't match v1 or v2. using SF_CRYPTO_V2.");
getCryptoVersion();
}

void Lifecycle.getInstance().emitTelemetry({
Expand Down

2 comments on commit 6774418

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 6774418 Previous: 032ce66 Ratio
Child logger creation 459259 ops/sec (±0.75%) 481355 ops/sec (±0.82%) 1.05
Logging a string on root logger 701199 ops/sec (±7.26%) 833088 ops/sec (±10.36%) 1.19
Logging an object on root logger 561798 ops/sec (±6.86%) 647330 ops/sec (±7.77%) 1.15
Logging an object with a message on root logger 17755 ops/sec (±186.97%) 4626 ops/sec (±217.39%) 0.26
Logging an object with a redacted prop on root logger 380326 ops/sec (±14.30%) 466686 ops/sec (±12.83%) 1.23
Logging a nested 3-level object on root logger 354811 ops/sec (±9.30%) 408661 ops/sec (±6.84%) 1.15

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 6774418 Previous: 032ce66 Ratio
Child logger creation 334908 ops/sec (±0.54%) 326646 ops/sec (±0.81%) 0.98
Logging a string on root logger 770131 ops/sec (±6.89%) 771188 ops/sec (±8.43%) 1.00
Logging an object on root logger 617597 ops/sec (±7.28%) 579782 ops/sec (±5.64%) 0.94
Logging an object with a message on root logger 9250 ops/sec (±199.72%) 7823 ops/sec (±201.05%) 0.85
Logging an object with a redacted prop on root logger 489021 ops/sec (±5.73%) 453782 ops/sec (±10.25%) 0.93
Logging a nested 3-level object on root logger 302112 ops/sec (±5.69%) 340874 ops/sec (±5.83%) 1.13

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.