Skip to content

Commit

Permalink
chore: eslint remove rule since it's now in dev-scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Apr 9, 2024
1 parent 938d4fe commit 45d337b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .eslintrc.cjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,5 @@

module.exports = {
extends: ['eslint-config-salesforce-typescript', 'eslint-config-salesforce-license'],
rules: {
'no-param-reassign': ['error', { props: true }],
},
root: true,
};

3 comments on commit 45d337b

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 45d337b Previous: 938d4fe Ratio
Logging an object with a message on root logger 3033 ops/sec (±243.18%) 32191 ops/sec (±181.29%) 10.61

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 45d337b Previous: 938d4fe Ratio
Child logger creation 477321 ops/sec (±1.59%) 464749 ops/sec (±1.29%) 0.97
Logging a string on root logger 838752 ops/sec (±8.81%) 841174 ops/sec (±9.66%) 1.00
Logging an object on root logger 626767 ops/sec (±5.51%) 620394 ops/sec (±7.81%) 0.99
Logging an object with a message on root logger 3033 ops/sec (±243.18%) 32191 ops/sec (±181.29%) 10.61
Logging an object with a redacted prop on root logger 427078 ops/sec (±10.51%) 504109 ops/sec (±7.14%) 1.18
Logging a nested 3-level object on root logger 363138 ops/sec (±7.85%) 23025 ops/sec (±184.39%) 0.06340564743981626

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 45d337b Previous: 938d4fe Ratio
Child logger creation 322336 ops/sec (±0.78%) 317808 ops/sec (±0.74%) 0.99
Logging a string on root logger 719769 ops/sec (±11.54%) 734050 ops/sec (±6.71%) 1.02
Logging an object on root logger 563980 ops/sec (±5.47%) 610083 ops/sec (±6.10%) 1.08
Logging an object with a message on root logger 12298 ops/sec (±188.97%) 10501 ops/sec (±200.35%) 0.85
Logging an object with a redacted prop on root logger 479588 ops/sec (±5.70%) 427980 ops/sec (±16.50%) 0.89
Logging a nested 3-level object on root logger 334940 ops/sec (±5.66%) 323028 ops/sec (±4.63%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.