-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter notebook basic example #1754
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mecoli1219 <[email protected]>
@Mecoli1219 please check the failing docs build. Fixing it should be straightforward. Thank you! |
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
@davidmirror-ops I'd like to get your input on the categorization of this example. I'm considering whether it should be in tutorial, integration, or the current |
``` | ||
|
||
```{image} https://img.shields.io/badge/Blog-Interactive-blue?style=for-the-badge | ||
:target: https://hackmd.io/@1E0FEh2MS_OpXGUAjEFIOQ/ByTTT821Jl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is going to change as the end goal is to host this post on flyte.org right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, correct. However, if this is going to be moved into the basics folder, I don't think this README.md
file is needed
@Mecoli1219 I think |
Signed-off-by: Mecoli1219 <[email protected]>
@davidmirror-ops @samhita-alla Can you help me review this PR? Thanks |
shouldn't this be updated in the flyte repo: https://github.com/flyteorg/flyte/tree/master/docs/user_guide/basics? @davidmirror-ops do you know? |
@samhita-alla excellent question. Both rendering the notebook as-is on a page in the flyte repo or keeping it in flytesnacks seems to require enabling one of the supported Sphynx extensions. |
@samhita-alla Oh... I finally understand what you mean. I'll open a PR in the flyte repo that updates this example in the basics example directory. |
@Mecoli1219 I think we want the example in the flytesnacks repo, but we may need to add the extension. If there's a way to get a preview URL, that'd be helpful. The preview URL link included in the checks doesn’t have the user guide, so it’s hard to confirm if the docs are rendering correctly. |
@samhita-alla I am not sure what we are expecting now. As far as I know, we are only adding the Does this align with what you were thinking? |
@Mecoli1219 Agree with creating a new page on the |
Got it! Let me try it out. By the way, I think placing the interactive mode content in Flyte Fundamentals would be more appropriate for the context. |
flyteorg/flyte#5907