Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4445 Fix feast jupyter notebook #1737

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manishdait
Copy link

Fix the port aling for minio Url for the feast jupyter notebook.

@davidmirror-ops
Copy link
Contributor

@manishdait thanks. Please link this PR to the originating issue using any of the Github supported keywords (ie "closes #xyz"). Also, the issue includes testing that the plugin works as expected. This would include running a sandbox instance (flytectl demo run) and following the steps in the tutorial. Let us know if you need help with that. Once it's done, please attach evidence that it works or report any issue with the plugin here please.

@manishdait
Copy link
Author

@manishdait thanks. Please link this PR to the originating issue using any of the Github supported keywords (ie "closes #xyz"). Also, the issue includes testing that the plugin works as expected. This would include running a sandbox instance (flytectl demo run) and following the steps in the tutorial. Let us know if you need help with that. Once it's done, please attach evidence that it works or report any issue with the plugin here please.

Hi, @davidmirror-ops , Can you provide me the resources for flytectl demo run tutorial.

@davidmirror-ops
Copy link
Contributor

@manishdait thanks. Please link this PR to the originating issue using any of the Github supported keywords (ie "closes #xyz"). Also, the issue includes testing that the plugin works as expected. This would include running a sandbox instance (flytectl demo run) and following the steps in the tutorial. Let us know if you need help with that. Once it's done, please attach evidence that it works or report any issue with the plugin here please.

Hi, @davidmirror-ops , Can you provide me the resources for flytectl demo run tutorial.

OMG sorry, it's flytectl demo start. Just install flytekit (pip install flytekit) and ensure you have a container daemon on your computer (Docker desktop typically). Let me know if you run into issues

@manishdait
Copy link
Author

Hi @davidmirror-ops,
While testing the changes, the create_bucket task was successful, but the featurize task encountered an error. As shown in the images, when I accessed the ZIP file link, the data was no longer available.
Screenshot from 2024-10-11 08-46-51
Screenshot from 2024-10-11 08-46-29

@manishdait
Copy link
Author

manishdait commented Oct 11, 2024

Link of horse_colic.db

Could you please suggest some possible solutions

@davidmirror-ops
Copy link
Contributor

@manishdait thanks, great work so far. I see that the link to the dataset is not valid anymore and it is defined here.
Could you try updating that line to this URL where the dataset seems to live now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants