Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to allow user to set bottom bar backgrond color along w… #740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krishnajithapa
Copy link

@krishnajithapa krishnajithapa commented Jun 18, 2023

There was an issue reported where user was not able to see bottom bar button when background color was white. So i have added parameter to let user specify the background and button color.

@diegotori
Copy link
Collaborator

diegotori commented Jul 2, 2023

@krishnajithapa thanks for your PR.

I think that the changes should be present in ChewieController if they are not overridden in Chewie by the user.

In other words, ChewieController should hold immutable Color properties related to this PR, and they should be used in MaterialControls as well as MaterialDesktopControls. If those two classes specify an optional custom color value, then use those values, otherwise fallback to the controller.

Chewie, PlayerWithControls, and AdaptiveControls should funnel the user-defined optional Color properties into MaterialControls and MaterialDesktopControls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants