-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Add back the device name with the running tab #7948
♻️ Add back the device name with the running tab #7948
Conversation
5f69c50
to
6d21c82
Compare
6d21c82
to
4096930
Compare
myDisplayName
to myDisplayNameView
to add back the device name with the running tabThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. The Flutter IJ plugin doesn't have tests for changes like this which is unfortunately. @AlexV525, I have not had a chance to test / validate this change myself, but would be very happy to have it land. If you have cycles, do add a few notes point out the history here in the code, and rebase to recent changes on |
I've added a few comments that indicate what the code is trying to do and why, also with src links to the InteliiJ Platform SDK. The branch is also updated. |
Recovers the ability of #6774.
Fixes #7605
Fixes #7539
myDisplayName
no longer exists in thecom.intellij.execution.ui.RunContentDescriptor
, it has been replaced by aMutableReactiveProperty
myDisplayNameView
since 2024 builds.2024+
myDisplayNameView
2023
myDisplayName
Pre-launch Checklist
///
).