-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh311 regex rules config ide #314
Open
cristina-constantinescu
wants to merge
19
commits into
GH220-code-mirror-mobile
Choose a base branch
from
GH311-regex-rules-config-ide
base: GH220-code-mirror-mobile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gh311 regex rules config ide #314
cristina-constantinescu
wants to merge
19
commits into
GH220-code-mirror-mobile
from
GH311-regex-rules-config-ide
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the mode the icon url is received - Used the new pattern, with new Property().set.set... - Add some comments - Changed a logger call, reducing the chance of often display
resolveSelectedItem to the interface. Also fixed a typo
Changed the view from propertiesList to propertiesView
- made some UI improvments - made some styling - replaced PropertiesItemRenderer with PropertyItemRenderer - removed PropertiesItemRenderer and all it's references
Conflicts: org.flowerplatform.codesync/src/org/flowerplatform/codesync/CodeSyncPropertiesProvider.java org.flowerplatform.editor.model/src/org/flowerplatform/editor/model/properties/DiagramPropertiesProvider.java org.flowerplatform.properties/src/org/flowerplatform/properties/PropertiesService.java org.flowerplatform.properties/src/org/flowerplatform/properties/providers/IPropertiesProvider.java org.flowerplatform.web/src/org/flowerplatform/web/properties/FilePropertiesProvider.java
displayed - Unsubscribe the view at closing - Removed the view from the default perspective
Added recyclable renderers
GH311-regex-rules-config-ide Conflicts: org.flowerplatform.web/flex_src/org/flowerplatform/web/layout/DefaultPerspective.as
refreshes with wrong x & y
explorer tree from permissions panel
classes from regex.ide to regex
user if error occurs when session.find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial implementation
created before merging with #21