Dualsense edge buttons #62
Open
+49
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added try except around thread code to handle the IOError raised by hidapi. -added 'connected' property to indicate when controller is disconnected. (cherry picked from commit a5ed419)
(cherry picked from commit 6aeeee1)
(cherry picked from commit f58c61b)
resolve dpad down left issue
…eptions Bugfix/handle hidapi exceptions in sendReport
|
Changed to merge to dev branch and added some comments |
flok
reviewed
Jan 28, 2025
| @@ -107,12 +115,17 @@ def init(self) -> None: | |||
| """ | |||
| initialize module and device states. Starts the sendReport background thread at the end | |||
| """ | |||
| self.device: hidapi.Device = self.__find_device() | |||
| self.device, self.is_edge = self.__find_device() | |||
There was a problem hiding this comment.
Could we readd a type hint for device and is_edge here again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reading the DualSense Edge buttons.
Added a way to error out if the buttons are unavailable so code should check the
is_edgevariable added topydualsense