Merge flipper-cloud into flipper gem #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnunemaker
reviewed
Jul 21, 2023
|
I think overall this looks good. We can release as rc1 for 0.29 or something to gain confidence that we did it right without messing people up. I can update boxoutsports.com, thewatcharchive.com and southbendwatch.co to see how it works. |
bkeepers
force-pushed
the
the-one-true-gem
branch
from
0864e26
to
4e4decb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges
flipper-cloudgem intoflipperand only configures cloud if theFLIPPER_CLOUD_TOKENis set.Alternative to #739