Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Combined addition and multiplication for fmpz_mpoly #994

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

[WIP] Combined addition and multiplication for fmpz_mpoly #994

wants to merge 54 commits into from

Commits on Jul 1, 2021

  1. Initial version of the addmul code; only does a single, multi-ary 

    multiplication; no optimization for small coefficients or small
exponents; no documentation
    @BrentBaccala
    BrentBaccala committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    fcc7250 View commit details
    Browse the repository at this point in the history

  2. minor cleanup; improve variable names

    @BrentBaccala
    BrentBaccala committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    0b493f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. addmul: add triple multiplication test case

    @BrentBaccala
    BrentBaccala committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    10c50d6 View commit details
    Browse the repository at this point in the history

  2. Bug fixes exposed by triple multiplication test case: 

       1. maxfields wasn't computed correctly
   2. exponent offsets are multiplied by "N"
   3. testing a candidate multiindex to see it it's on an edge
      is more complicated than just checking if it's less than 0
    @BrentBaccala
    BrentBaccala committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    fd3aca0 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. addmul: remove the special case code for small coefficients and small… 

    … exponents,

that were commented out anyway because they haven't been ported
    @BrentBaccala
    BrentBaccala committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    02613ca View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. addmul: convert to new calling convention

    @BrentBaccala
    BrentBaccala committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    6fcd257 View commit details
    Browse the repository at this point in the history

  2. name change fmpz_mpoly_addmul -> fmpz_mpoly_addmul_multi

    @BrentBaccala
    BrentBaccala committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    92a8ca3 View commit details
    Browse the repository at this point in the history

  3. addmul_multi - enhance code to do addition of multiple terms. 

    Works on existing single-term test cases, but hasn't been tested multi-term yet.
    @BrentBaccala
    BrentBaccala committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    70e0c1a View commit details
    Browse the repository at this point in the history

  4. addmul_multi: first multi-term product f*g+f*h passes test

    @BrentBaccala
    BrentBaccala committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    83232ba View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. addmul_multi - add aliasing tests

    @BrentBaccala
    BrentBaccala committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    c9f39d9 View commit details
    Browse the repository at this point in the history

  2. addmul_multi - change first test case to more closely mimic "mul" tes… 

    …t case
    @BrentBaccala
    BrentBaccala committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    a4ae9c6 View commit details
    Browse the repository at this point in the history

  3. addmul_multi - remove lingering variables from unused small coefficie… 

    …nt optimization
    @BrentBaccala
    BrentBaccala committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    b328b3a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. addmul_multi: BUG FIX make sure largest polynomial is always first

    @BrentBaccala
    BrentBaccala committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    6022f27 View commit details
    Browse the repository at this point in the history

  2. addmul_multi: make heap dynamically sized

    @BrentBaccala
    BrentBaccala committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    98f60d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. addmul_multi: make exponents dynamically sized

    @BrentBaccala
    BrentBaccala committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    2951c0b View commit details
    Browse the repository at this point in the history

  2. addmul_multi: dynamically size chain

    @BrentBaccala
    BrentBaccala committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    ed1d09a View commit details
    Browse the repository at this point in the history

  3. addmul_multi: make Q dynamically sized

    @BrentBaccala
    BrentBaccala committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    f222c87 View commit details
    Browse the repository at this point in the history

  4. addmul_multi - use unsigned short for hind array

    @BrentBaccala
    BrentBaccala committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    4f30b7b View commit details
    Browse the repository at this point in the history

  5. addmul_multi: allocate chain and heap in large enough blocks to avoid… 

    … alloca
    @BrentBaccala
    BrentBaccala committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    87f6041 View commit details
    Browse the repository at this point in the history

  6. addmul_multi: remove limitation on size of input sequences

    @BrentBaccala
    BrentBaccala committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    22b8776 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. addmul_multi_threaded: add a multi-threaded version of addmul_multi

    @BrentBaccala
    BrentBaccala committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    cf8c34a View commit details
    Browse the repository at this point in the history

  2. addmul_multi_threaded - free malloc'ed data structures

    @BrentBaccala
    BrentBaccala committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    3b77482 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. addmul_multi_threaded - add new test case f*g + f*g = 2*f*g

    @BrentBaccala
    BrentBaccala committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    28efc70 View commit details
    Browse the repository at this point in the history

  2. addmul_multi (single and multi threaded version) - handle zero length… 

    … polynomials
    @BrentBaccala
    BrentBaccala committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    04a1aa3 View commit details
    Browse the repository at this point in the history

  3. addmul_multi_threaded - add 4 term test

    @BrentBaccala
    BrentBaccala committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    7e811e0 View commit details
    Browse the repository at this point in the history

  4. addmul_multi_threaded - bug fixes uncovered by 4 term test

    @BrentBaccala
    BrentBaccala committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    b78d5c4 View commit details
    Browse the repository at this point in the history

  5. addmul_multi_theaded - add more test cases to improve code coverage

    @BrentBaccala
    BrentBaccala committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    b1a90e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. fmpz_mpoly_addmul_multi - bug fix with test case to exercise it

    @BrentBaccala
    BrentBaccala committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    3aabcbe View commit details
    Browse the repository at this point in the history

  2. addmul_multi_threaded - minor typo on a pointer type

    @BrentBaccala
    BrentBaccala committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    c879701 View commit details
    Browse the repository at this point in the history

  3. addmul_multi_threaded - add a condition variable to pause and restart… 

    … threads
    @BrentBaccala
    BrentBaccala committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    a5b06e4 View commit details
    Browse the repository at this point in the history

  4. fmpz_mpoly_addmul_threaded - use slong instead of short in heap struc… 

    …ture
    @BrentBaccala
    BrentBaccala committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    4bab56d View commit details
    Browse the repository at this point in the history

  5. fmpz_mpoly_addmul_multi: another bug, another test case

    @BrentBaccala
    BrentBaccala committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5872000 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. addmul_multi_threaded: add a subroutine to print status messages as w… 

    …e run
    @BrentBaccala
    BrentBaccala committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    99e471f View commit details
    Browse the repository at this point in the history

  2. add an "output_function" to polynomials, and use it in addmul_multi_t… 

    …hreaded
    @BrentBaccala
    BrentBaccala committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    44e3411 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. addmul_multi: add context argument to output_function, and some bug f… 

    …ixes on output_function
    @BrentBaccala
    BrentBaccala committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    bd81ccb View commit details
    Browse the repository at this point in the history

  2. fmpz_mpoly_addmul_multi: bug fix with test case: stall-and-fill logic… 

    … in merge tree
    @BrentBaccala
    BrentBaccala committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    4cd5aa1 View commit details
    Browse the repository at this point in the history

  3. add some FLINT_ASSERTs that I added when trying to find the last bug

    @BrentBaccala
    BrentBaccala committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    d11b781 View commit details
    Browse the repository at this point in the history

  4. fmpz_mpoly_addmul_multi: add a 5-term sum test case

    @BrentBaccala
    BrentBaccala committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    be3e9b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. addmul_multi: revert adding a field to the fmpz_mpoly structure, 

    and instead pass 'output_function' as a function argument
    @BrentBaccala
    BrentBaccala committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    3ea194e View commit details
    Browse the repository at this point in the history

  2. fmpz_mpoly_addmul_multi: print status is now smarter about putting sp… 

    …aces at the ends of lines
    @BrentBaccala
    BrentBaccala committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    4389dcc View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. new function fmpz_mpoly_abstract_add

    @BrentBaccala
    BrentBaccala committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    346b869 View commit details
    Browse the repository at this point in the history

  2. forgot to commit include file declaration for abstract add

    @BrentBaccala
    BrentBaccala committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    5409b7a View commit details
    Browse the repository at this point in the history

  3. addmul_multi_threaded: add a 'bits' argument to output_function

    @BrentBaccala
    BrentBaccala committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    b6a449d View commit details
    Browse the repository at this point in the history

  4. bug fix in abstract add

    @BrentBaccala
    BrentBaccala committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    fcf4c21 View commit details
    Browse the repository at this point in the history

  5. bug fix in abstract add

    @BrentBaccala
    BrentBaccala committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    edd4af9 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. abstract_add: add a test harnass and fix some bugs exposed by it

    @BrentBaccala
    BrentBaccala committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    97cf6c8 View commit details
    Browse the repository at this point in the history

  2. add another test case to addmul_multi_threaded that passes with no pr… 

    …oblems
    @BrentBaccala
    BrentBaccala committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    db864f1 View commit details
    Browse the repository at this point in the history

  3. abstract_add and addmul_multi_threaded: call output_function a final 

    time with an index of -1 to indicate end-of-polynomial
    @BrentBaccala
    BrentBaccala committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    54159c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. addmul_multi_threaded - make sure we don't do anything with 'A' if ou… 

    …tput_function is set
    @BrentBaccala
    BrentBaccala committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    6367666 View commit details
    Browse the repository at this point in the history

  2. abstract_add: allow Blist to be NULL

    @BrentBaccala
    BrentBaccala committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    ce19d03 View commit details
    Browse the repository at this point in the history

  3. rename 'abstract' files to be 'abstract_add'

    @BrentBaccala
    BrentBaccala committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    cb2cdc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. adjust addmul_multi_threaded_abstract function signature to take a vo… 

    …id *
    @BrentBaccala
    BrentBaccala committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    b86b7a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. silence some compiler warnings

    @BrentBaccala
    BrentBaccala committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    e873a32 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. fmpz_mpoly_abstract_add's input_function now takes ulong index instea… 

    …d of slong,

which makes more sense and helps silence compiler warnings in SAGE
    @BrentBaccala
    BrentBaccala committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e91bf0f View commit details
    Browse the repository at this point in the history