Fix checking of label suffix #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing patterns in X86_64_PATTERN from X86_64_ADX_PATTERN - Add zen5 in X86_64_ADX_PATTERN
albinahlback
force-pushed
the
fix_label
branch
2 times, most recently
from
0d317ef to
6bd7e01
Compare
During bootstrapping, config.guess is always present.
As it is only used for x86_64 and ARM64 in longlong_asm_gnu.h, only check the suffix when host is either of these architectures.
albinahlback
added a commit
to albinahlback/flint
that referenced
this pull request
Mar 11, 2025
* Update X86_64_PATTERN and X86_64_ADX_PATTERN - Add missing patterns in X86_64_PATTERN from X86_64_ADX_PATTERN - Add zen5 in X86_64_ADX_PATTERN * Add Zen 5 recognition in config.(guess|sub) * Check presence of install-sh instead of config.guess During bootstrapping, config.guess is always present. * Conditionally check for LABEL_SUFFIX As it is only used for x86_64 and ARM64 in longlong_asm_gnu.h, only check the suffix when host is either of these architectures. * Set CFLAGS and temporary param_path for Zen 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add Zen 5 to list of recognized CPUs.