Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-packages.md: create page. #1

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented Aug 4, 2020

No description provided.

git-packages.md Outdated
Comment on lines 58 to 67
The following example uses
[git-clone(1)](https://man.voidlinux.org/git-clone.1).

```
do_fetch() {
git clone <project_url> ${wkrsrc} --depth 1
cd ${wrksrc}
git checkout <feature_branch>
}
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add a text paragraph that wasn't an item in the list because otherwise vmdfmt folds the code block into the list using inline code. Might be a bug.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git-packages.md Outdated
Comment on lines 58 to 67
The following example uses
[git-clone(1)](https://man.voidlinux.org/git-clone.1).

```
do_fetch() {
git clone <project_url> ${wkrsrc} --depth 1
cd ${wrksrc}
git checkout <feature_branch>
}
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, okay.

totally different content to merge later
>>>>>>> new_branch_to_merge_later
```

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it might be useful to explain what the annotations mean, and how one resolves conflicts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I will try to search for a good article to link to, perhaps. Not sure I'd do a great job of it.

@fosslinux
Copy link

Is this intended as a packaging guide for void into the repositories? We almost never accept -git packages into the repo... I think this should be explicitly stated.

@ericonr
Copy link
Contributor Author

ericonr commented Aug 4, 2020

Is this intended as a packaging guide for void into the repositories?

Not at all, it is for personal use only. I can make that explicit. The part about including patches could lead to changes that would be accepted into the repos, tho.

@flexibeast
Copy link
Owner

Yes, it would probably be good to not only make it explicit, but to use language along the lines of void-packages CONTRIBUTING, which says:

Please note that we do not accept any packages containing non-release versions, such as specific git- or svn-revisions anymore.

which says "anymore" because there are (i believe) still some existing templates that do use a specific revision.

Hopefully that might forestall "But what about <font_x> being in the repos?"-type issues. :-)

@mobinmob
Copy link

mobinmob commented Aug 5, 2020

Yes, it would probably be good to not only make it explicit, but to use language along the lines of void-packages CONTRIBUTING, which says:

Please note that we do not accept any packages containing non-release versions, such as specific git- or svn-revisions anymore.

I maintain mtpaint (the package/template) which uses a git revision in the template in order to pull from gh, because the author does not tag releases but does commits with a release number as a message : wjaguar/mtPaint@ff0a801

That is probably outside the scope of the policy statement but... these exceptions exist.

@fosslinux
Copy link

Ok, that is a fair point. I guess -git versions are normally thought of as being the "latest upstream straight from master", rather than a release, even if it is just a commit.. rpi-kernel would be another example.

@ericonr
Copy link
Contributor Author

ericonr commented Aug 17, 2020

Updated!

@ericonr ericonr changed the title [WIP] git-packages.md: create page. git-packages.md: create page. Aug 17, 2020
@ericonr
Copy link
Contributor Author

ericonr commented Aug 17, 2020

Thanks for the suggestions, updated!

@flexibeast flexibeast merged commit ca760e1 into flexibeast:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants