Add energy bandgap monitors for the CHARGE simulations. #2337
Conversation
| @@ -40,6 +40,26 @@ class SteadyFreeCarrierMonitor(HeatChargeMonitor): | |||
| ) | |||
|
|
|||
|
|
|||
| class SteadyEnergyBandMonitor(HeatChargeMonitor): | |||
| """ | |||
| Free-carrier monitor for Charge simulations. | |||
There was a problem hiding this comment.
Free-carrier -> Energy band
| ) | ||
|
|
||
| def field_name(self, val: str = "") -> str: | ||
| """Gets the name of the fields to be plot.""" |
There was a problem hiding this comment.
plotted
I see that this is just copied from above, so could you correct it everywhere?
| return "Ec, Ev, Ei, Efn, Efp" | ||
|
|
||
| @add_ax_if_none | ||
| def plot_slice(self, axis: Axis, pos: float, voltage: float, ax: Ax = None) -> Ax: |
There was a problem hiding this comment.
As a general comment (@marc-flex ) in the EM data plot_field we do not explicitly pass things like frequency, mode inde, etc. We just bundle all unknown arguments into **sel_kwargs and pass this to .sel, which allows a bit more freedom. So here, voltage would go into these not-explicitly-defined arguments. Then someone could even do plot_slice(... , voltage=1, method="nearest") to avoid errors that might sometimes happen if they pass a value that is slightly off from an actual recorded value (sometimes just due to numerical precision...)
|
Thanks! Should also add a test somewhere around here |
|
Updated the code and created the new PR #2344 |
Add energy bandgap monitors for the CHARGE simulations.