add batch_id for Batch #2252
Draft
add batch_id for Batch #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
requested changes
Feb 17, 2025
Comment on lines
+487
to
+492
| batch_id: str = pd.Field( | ||
| f"bat-{uuid.uuid4()}", | ||
| title="BatchId", | ||
| description="The batchId to run as a batch.", | ||
| ) | ||
|
|
There was a problem hiding this comment.
This implementation will currently lead to the same default batch id for every batch in the same python session, i.e. if you submit multiple batches, they will all have the same batch id.
Also more generally I'm not a big fan of using uuid's here because they won't be reproducible across multiple sessions. The batch id's should be unique and deterministic, e.g. based on the hashes of the simulations that are contained in the batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.