Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Also set inValidNode when CSP starts with comment #27376

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

TsekNet
Copy link
Contributor

@TsekNet TsekNet commented Mar 21, 2025

Addresses #26443 (comment) after #27176 was merged.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Sorry, something went wrong.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.78%. Comparing base (af40739) to head (58656ab).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27376      +/-   ##
==========================================
- Coverage   63.83%   63.78%   -0.05%     
==========================================
  Files        1737     1737              
  Lines      165290   165147     -143     
  Branches     4429     4429              
==========================================
- Hits       105507   105337     -170     
- Misses      51563    51580      +17     
- Partials     8220     8230      +10     
Flag Coverage Δ
backend 64.66% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iansltx iansltx added the #g-mdm MDM product group label Mar 21, 2025
Copy link
Member

@georgekarrv georgekarrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@georgekarrv georgekarrv merged commit e187b02 into fleetdm:main Mar 21, 2025
24 of 26 checks passed
@TsekNet TsekNet deleted the 26443-xml-comments-fixed branch March 21, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#g-mdm MDM product group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants